Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5159 - gif display error add "coalesce" options #4561

Merged
merged 14 commits into from
Nov 22, 2023

Conversation

SevenWaysDP
Copy link
Contributor

@SevenWaysDP SevenWaysDP commented Nov 16, 2023

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@@ -44,6 +44,7 @@ export class PreviewGeneratorService {
const { format, width } = previewParams;

const preview = this.imageMagick(original.data);
preview.coalesce();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just for test

@SevenWaysDP SevenWaysDP changed the base branch from main to BC-5583-display-pdf-preview November 17, 2023 14:12
Base automatically changed from BC-5583-display-pdf-preview to main November 22, 2023 12:52
@SevenWaysDP SevenWaysDP enabled auto-merge (squash) November 22, 2023 13:06
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@SevenWaysDP SevenWaysDP merged commit 391aab8 into main Nov 22, 2023
46 of 47 checks passed
@SevenWaysDP SevenWaysDP deleted the bc-5159-gif-display branch November 22, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants